Merged
Conversation
Member
eileencodes
commented
Apr 16, 2020
- Removes EOL'd Ruby and Rails versions
- Adds a Gemfile for 6.0
- Fixes the test failures we were seeing on new PRs on relative file renders
Master is on 6.1 so we should add a Gemfile for 6.0
Rails 5.0 and 5.1 as well as Ruby 2.2, 2.3, and 2.4 are EOL. We can remove them. Adds 6.0 Gemfile for testing.
rails/rails#35688 deprecated calling `render file` and letting it lookup the file from anywhere. This was deprecated in 6.0 and removed in 6.1, which is why travis was failing for new PRs.
b5c1e5c to
951c784
Compare
These tests are now failing because of changes made in rails/rails#35688. This causes the instrumentation for `@_files` to not get run, but also don't think this should be supported since that instrumentation is for templates and now files are just rendered as files not as templates.
951c784 to
9acf9b7
Compare
|
🎉 This will help the Ruby 2.7 PRs along. Thanks!! |
jhawthorn
approved these changes
May 5, 2020
Merged
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.