Skip to content

Fix kwargs usage for Ruby 2.7#51

Closed
aubinlrx wants to merge 1 commit intorails:masterfrom
aubinlrx:tweak/deprecation_warning_ruby_27
Closed

Fix kwargs usage for Ruby 2.7#51
aubinlrx wants to merge 1 commit intorails:masterfrom
aubinlrx:tweak/deprecation_warning_ruby_27

Conversation

@aubinlrx
Copy link
Contributor

@aubinlrx aubinlrx commented Mar 26, 2020

This PR intend to fix Ruby 2.7 deprecation warning:

gems/rails-controller-testing-1.0.4/lib/rails/controller/testing/integration.rb:13: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

I've add a second **options args to keep symmetry with actionpack/lib/action_dispatch/testing/integration.rb:352

@aubinlrx aubinlrx force-pushed the tweak/deprecation_warning_ruby_27 branch 3 times, most recently from 1986322 to b10d149 Compare March 26, 2020 11:31
@aubinlrx aubinlrx closed this Mar 26, 2020
@aubinlrx aubinlrx force-pushed the tweak/deprecation_warning_ruby_27 branch from b10d149 to 21014e4 Compare March 26, 2020 11:43
@aubinlrx aubinlrx reopened this Mar 26, 2020
@aubinlrx aubinlrx force-pushed the tweak/deprecation_warning_ruby_27 branch from b0b4b14 to ca35f7b Compare March 26, 2020 11:53
@aubinlrx
Copy link
Contributor Author

aubinlrx commented Mar 26, 2020 •
edited
Loading

The CI seems to be broken on master when building my branch without changes I got the same errors.

@aubinlrx aubinlrx force-pushed the tweak/deprecation_warning_ruby_27 branch 4 times, most recently from 3ad3830 to 12b2678 Compare March 26, 2020 12:53
@aubinlrx aubinlrx force-pushed the tweak/deprecation_warning_ruby_27 branch from 12b2678 to e676b5a Compare March 26, 2020 12:55
@jhawthorn jhawthorn mentioned this pull request May 5, 2020
Merged
@jhawthorn
Copy link
Member

jhawthorn commented May 5, 2020

Thank you! This was merged with small changes in #58 ❤️

@jhawthorn jhawthorn closed this May 5, 2020
@lucascaton lucascaton mentioned this pull request May 12, 2020
Closed
@scottohara scottohara mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aubinlrx @jhawthorn