Fix renderable arity checks when method is overridden#57360
Merged
Conversation
4 tasks
seanpdoyle
reviewed
May 13, 2026
Use Kernel#method explicitly when checking a renderable object's render_in arity, so objects that define their own method reader do not break rendering. Along with a regression test. More context: rails#50623 (comment)
619bfcc to
4870c5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Kernel#methodexplicitly when checking a renderable object's render_in arity, so objects that define their own method reader do not break rendering. Along with a regression test.More context: #50623 (comment)
cc @rafaelfranca / @seanpdoyle
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]