Report Memcached and Redis cache errors to Rails.error#43712
Merged
byroot merged 1 commit intorails:mainfrom Nov 24, 2021
Merged
Report Memcached and Redis cache errors to Rails.error#43712byroot merged 1 commit intorails:mainfrom
byroot merged 1 commit intorails:mainfrom
Conversation
Ref: rails#43472 We swallow these exceptions because it makes sense for a cache to fallback to a cache miss in case of transcient failures. However there's value in reporting these to the application owners so that they can be alerted that something undesirable happened.
rafaelfranca
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #43472
We swallow these exceptions because it makes sense for a cache to
fallback to a cache miss in case of transcient failures.
However there's value in reporting these to the application
owners so that they can be alerted that something undesirable happened.
cc @rafaelfranca