Skip to content

[ci skip]Updated abbreviation for single table inheritance.#41992

Merged
kamipo merged 1 commit intorails:mainfrom
ashiksp:update-sti-abbreviation
Apr 17, 2021
Merged

[ci skip]Updated abbreviation for single table inheritance.#41992
kamipo merged 1 commit intorails:mainfrom
ashiksp:update-sti-abbreviation

Conversation

@ashiksp
Copy link
Contributor

@ashiksp ashiksp commented Apr 15, 2021

Summary

Updated abbreviation for single table inheritance as STI in the docs.
Rest of the occurrences looks correct.

Copy link

@TonsOfFun TonsOfFun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the comments and the test more comprehensible. sti looks like a typo STI looks like an abbreviation.

Since we're here we also might consider changing the sentence:

    # superclass. This is mostly useful in relation to single-table
    # inheritance structures where you want a subclass to appear as the
    # superclass.

To include (STI) and remove the hyphenation of single-table:

    # superclass. This is mostly useful in relation to single table
    # inheritance (STI) structures where you want a subclass to appear as the
    # superclass.

We're also referring to it as "single-table" inheritance, so we might want to remove the quotes.

@ashiksp ashiksp force-pushed the update-sti-abbreviation branch from eb86f0c to 8e1b191 Compare April 16, 2021 06:23
@kamipo kamipo merged commit 10f031f into rails:main Apr 17, 2021
@ashiksp ashiksp deleted the update-sti-abbreviation branch June 18, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants