[ci skip]Updated abbreviation for single table inheritance.#41992
Merged
kamipo merged 1 commit intorails:mainfrom Apr 17, 2021
Merged
[ci skip]Updated abbreviation for single table inheritance.#41992kamipo merged 1 commit intorails:mainfrom
kamipo merged 1 commit intorails:mainfrom
Conversation
marivaldo
approved these changes
Apr 16, 2021
TonsOfFun
suggested changes
Apr 16, 2021
TonsOfFun
left a comment
There was a problem hiding this comment.
This makes the comments and the test more comprehensible. sti looks like a typo STI looks like an abbreviation.
Since we're here we also might consider changing the sentence:
# superclass. This is mostly useful in relation to single-table
# inheritance structures where you want a subclass to appear as the
# superclass.
To include (STI) and remove the hyphenation of single-table:
# superclass. This is mostly useful in relation to single table
# inheritance (STI) structures where you want a subclass to appear as the
# superclass.
We're also referring to it as "single-table" inheritance, so we might want to remove the quotes.
eb86f0c to
8e1b191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated abbreviation for single table inheritance as STI in the docs.
Rest of the occurrences looks correct.