Allow delegated_type to be specified primary_key and foreign_key#40865
Merged
rafaelfranca merged 1 commit intorails:masterfrom Dec 18, 2020
Merged
Allow delegated_type to be specified primary_key and foreign_key#40865rafaelfranca merged 1 commit intorails:masterfrom
rafaelfranca merged 1 commit intorails:masterfrom
Conversation
Member
There was a problem hiding this comment.
Can you update the documentation to reflect those new options?
d872d3a to
d1b8c83
Compare
Since delegated_type assumes that the foreign_key ends with `_id`, `singular_id` defined by it does not work when the foreign_key does not end with `id`. This commit fixes it by taking into account `primary_key` and `foreign_key` in the options.
d1b8c83 to
941c564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since delegated_type assumes that the foreign_key ends with
_id,singular_iddefined by it does not work when the foreign_key does not end withid.This PR fixes it by taking into account
primary_keyandforeign_keyin the options.Other Information