Test with my branch enabling ruby2_keywords by default#38299
Closed
eregon wants to merge 4 commits intorails:masterfrom
Closed
Test with my branch enabling ruby2_keywords by default#38299eregon wants to merge 4 commits intorails:masterfrom
eregon wants to merge 4 commits intorails:masterfrom
Conversation
* With ruby2_keywords by default, the 2.6 behavior is preserved for those tests.
* Branch based on Ruby 2.7.0, with changes in ruby/ruby@ruby_2_7...eregon:ruby2_keywords-by-default-27 * See https://bugs.ruby-lang.org/issues/16463 * Docker image from https://hub.docker.com/repository/docker/eregon/ruby
Contributor
Author
|
@rafaelfranca @kamipo @amatsuda Could one of you authorize the build? https://buildkite.com/rails/rails/builds/66631#60fe781e-383f-4158-b540-a13ce28e5bfc says And needs manual approval it seems. Update: approved by Rafael, thanks! |
* With ruby2_keywords by default, the 2.6 behavior is preserved for those tests.
This was referenced Jan 23, 2020
Contributor
Author
|
Testing done, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruby/ruby@ruby_2_7...eregon:ruby2_keywords-by-default-27
I'd like to run Rails tests with that branch to see if any test fails.