Skip to content

Add changelog for #32956 [ci skip]#33121

Merged
kamipo merged 1 commit intorails:masterfrom
bogdanvlviv:add-changelog-for-32956
Jun 11, 2018
Merged

Add changelog for #32956 [ci skip]#33121
kamipo merged 1 commit intorails:masterfrom
bogdanvlviv:add-changelog-for-32956

Conversation

@bogdanvlviv
Copy link
Contributor

Add mention about default value of config.active_model.i18n_full_message.

@rails-bot
Copy link

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deleted a blank line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentionally. I've returned it back.

@bogdanvlviv bogdanvlviv force-pushed the add-changelog-for-32956 branch 2 times, most recently from e93e9bc to 78dce2b Compare June 11, 2018 22:32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in activemodel/CHANGELOG.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is already there.

Add mention about default value of `config.active_model.i18n_full_message`.
@bogdanvlviv bogdanvlviv force-pushed the add-changelog-for-32956 branch from 78dce2b to f009e55 Compare June 11, 2018 22:39
@kamipo kamipo merged commit 7a35066 into rails:master Jun 11, 2018
@bogdanvlviv bogdanvlviv deleted the add-changelog-for-32956 branch June 11, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants