Skip to content

Remove leftover blank sqlite3 file after in memory handler tests.#32400

Merged
pixeltrix merged 1 commit intorails:masterfrom
utilum:cleanup_after_sqlite3_connection_handler_test
Apr 1, 2018
Merged

Remove leftover blank sqlite3 file after in memory handler tests.#32400
pixeltrix merged 1 commit intorails:masterfrom
utilum:cleanup_after_sqlite3_connection_handler_test

Conversation

@utilum
Copy link
Contributor

@utilum utilum commented Mar 31, 2018

Summary

Fixes a glitch introduced in 0392946 that leaves an empty file, /activerecord/db/primary.sqlite3 in the fs.

@rails-bot
Copy link

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just use FileUtils.rm_rf "db" instead of the two commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite. Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above - just use FileUtils.rm_rf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above - done.

@utilum utilum force-pushed the cleanup_after_sqlite3_connection_handler_test branch from ab878c3 to ca82d47 Compare April 1, 2018 06:30
@pixeltrix pixeltrix merged commit 8d93107 into rails:master Apr 1, 2018
@pixeltrix
Copy link
Contributor

@utilum thanks! 👍

@utilum utilum deleted the cleanup_after_sqlite3_connection_handler_test branch April 1, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants