Conversation
|
Not sure if this needs an upgrade path? |
…ttps://www.google.com/#q=sha1+deprecation for more. Upgrade to default to SHA256, instead of the deprecated SHA1 hashing in places that use signing and encryption.
|
^^ I think we're going to need some kind of |
|
Needs an upgrade path. It'd break all existing browser sessions when an app upgrades Rails versions. This would be much simpler if we offered a way to rotate message verifiers. Read with new verifier and fall back to old verifier (possibly with a different key or digest or …); write with new verifier. |
|
@jeremy something like cookies |
|
Cool, we need to get #18772 in. Let me do a recreation on that. |
|
message_encryptor.rb line 43 still mentions SHA1 as the default in this PR. While we're changing defaults: it seems it is better to switch to an AEAD mode such as |
|
Just want to point out that it is now possible to rotate from SHA1 signed cookies to SHA256 (or SHA512 for that matter). This was brought in my #29716. Please refer to the Security guide for more details: https://github.com/rails/rails/blob/04a7b7165ad204014c5850f62c921f7291d6ba5d/guides/source/security.md#rotating-encrypted-and-signed-cookies-configurations |
SHA1 has been deprecated by browser vendors, and mojority users. See https://www.google.com/#q=sha1+deprecation for more.
Upgrade to default to SHA256, instead of the deprecated SHA1 hashing in places that use signing and encryption.