Evented File System Monitoring#20785
Conversation
There was a problem hiding this comment.
It seems like you're indentation is off. Can you switch to use 2 spaces as the indentation unit throughout? 😄
It would look like this:
module ActiveSupport
class FileEventedUpdateChecker
attr_reader :listener
# The rest of your code...
end
endRemember to strip whitespace at the end of every line too (and empty lines should have no spaces) 😄
|
I have made indentation according to convention. |
There was a problem hiding this comment.
Could you please remove this indentation?
There was a problem hiding this comment.
Yes I missed this one. I will remove that,
There was a problem hiding this comment.
IMO this comment needs to be more descriptive as to why / how performance will be improved - especially because in some environments (Windows, for instance) the "fast" version requires an additional gem.
|
Really excited to see Listen being used by Rails! ❤️ |
|
That's awesome! 💥 |
|
Hi @puneet24 could you please resolve conflicts here? |
|
Hi @fxn, I have resolved the conflicts in latest commit. |
|
@puneet24 thanks! GitHub still says this branch has conflicts... maybe you updated a different branch? |
No description provided.