Skip to content

RenderStreaming::StreamingTest fail with since https://github.com/rack/rack/pull/2195 #52066

@yahonda

Description

@yahonda

Steps to reproduce

Managed to reproduce CI failure at https://buildkite.com/rails/rails-nightly/builds/635#018ff9a7-967b-49b3-b352-0d4b87d6b2fa/1230-1239

git clone https://github.com/rails/rails
cd rails/actionpack
export RACK="head"
bundle update rack
bin/test test/controller/new_base/render_streaming_test.rb -n /test_rendering_with/

Expected behavior

It should pass.

Actual behavior

These tests fail.

$ bin/test test/controller/new_base/render_streaming_test.rb -n /test_rendering_with/
Running 9 tests in a single process (parallelization threshold is 50)
Run options: -n /test_rendering_with/ --seed 43709

# Running:

F

Failure:
RenderStreaming::StreamingTest#test_rendering_with_template_exception [test/controller/new_base/render_streaming_test.rb:89]:
Expected # encoding: US-ASCII
#    valid: true
"66" to be nil.


bin/test test/controller/new_base/render_streaming_test.rb:86

F

Failure:
RenderStreaming::StreamingTest#test_rendering_with_streaming_given_to_render [test/controller/new_base/render_streaming_test.rb:60]:
Expected # encoding: US-ASCII
#    valid: true
"37" to be nil.


bin/test test/controller/new_base/render_streaming_test.rb:57

F

Failure:
RenderStreaming::StreamingTest#test_rendering_with_streaming_no_layout [test/controller/new_base/render_streaming_test.rb:72]:
Expected # encoding: US-ASCII
#    valid: true
"21" to be nil.


bin/test test/controller/new_base/render_streaming_test.rb:69

F

Failure:
RenderStreaming::StreamingTest#test_rendering_with_layout_exception [test/controller/new_base/render_streaming_test.rb:83]:
Expected # encoding: US-ASCII
#    valid: true
"84" to be nil.


bin/test test/controller/new_base/render_streaming_test.rb:80

F

Failure:
RenderStreaming::StreamingTest#test_rendering_with_streaming_enabled_at_the_class_level [test/controller/new_base/render_streaming_test.rb:54]:
Expected # encoding: US-ASCII
#    valid: true
"37" to be nil.


bin/test test/controller/new_base/render_streaming_test.rb:51

F

Failure:
RenderStreaming::StreamingTest#test_rendering_with_streaming_do_not_override_explicit_cache_control_given_to_render [test/controller/new_base/render_streaming_test.rb:66]:
Expected # encoding: US-ASCII
#    valid: true
"37" to be nil.


bin/test test/controller/new_base/render_streaming_test.rb:63

.

Finished in 0.263055s, 26.6104 runs/s, 76.0298 assertions/s.
7 runs, 20 assertions, 6 failures, 0 errors, 0 skips
$

System configuration

Rails version: main branch

Ruby version: ruby 3.3.2 (2024-05-30 revision e5a195edf6) [x86_64-linux]

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions