Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d94263f
Choose a base ref
...
head repository: rails/rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5665fb5
Choose a head ref
  • 12 commits
  • 23 files changed
  • 1 contributor

Commits on Sep 3, 2019

  1. Passing in a Hash instance as non-kwargs parameters has to be braced … 

    …in Ruby 3.0 syntax

See https://bugs.ruby-lang.org/issues/14183 for details
    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    e69b5f5 View commit details
    Browse the repository at this point in the history

  2. Passing in a Hash instance as kwargs parameters requires the "double … 

    …splat" prefix

See https://bugs.ruby-lang.org/issues/14183 for details
    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    87b428c View commit details
    Browse the repository at this point in the history

  3. I18n.translate takes kwargs options

    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    e60c1bf View commit details
    Browse the repository at this point in the history

  4. :number is not a keyword argument

    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    1e4e093 View commit details
    Browse the repository at this point in the history

  5. subscribe block doesn't take keyword arguments

    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    575d4d1 View commit details
    Browse the repository at this point in the history

  6. Unify the API with Messages::Rotator::Verifier#verify that takes kwargs

    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    81230c6 View commit details
    Browse the repository at this point in the history

  7. Introduce keyword arguments for some AS::Cache methods 

    since RedisCacheStore#write_entry takes kwargs, we needed to kwargsify all these methods
in order to eliminate Ruby 2.7 warnings.

It's a little bit bigger patch than I expected, but it doesn't warn on Ruby 3,
and it doesn't introduce any incompatibility on loder rubies, so it may not be a bad thing anyway.
    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    3cfd6d1 View commit details
    Browse the repository at this point in the history

  8. Passing in a Hash instance as kwargs parameters requires the "double … 

    …splat" prefix
    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b5704f3 View commit details
    Browse the repository at this point in the history

  9. Passing in a Hash instance as non-kwargs parameters has to be braced … 

    …in Ruby 3.0 syntax
    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    08ee9d1 View commit details
    Browse the repository at this point in the history

  10. RequestEncoder.register_encoder takes keyworded arguments

    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    614b552 View commit details
    Browse the repository at this point in the history

  11. These RequestHelpers' methods take keyword arguments

    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    b7e591a View commit details
    Browse the repository at this point in the history

  12. send with **options only when options is not empty 

    or this causes "ArgumentError: wrong number of arguments (given 1, expected 0)" in some methods
    @amatsuda
    amatsuda committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    5665fb5 View commit details
    Browse the repository at this point in the history
Loading