Update dependency on sqlite3 gem to >= 2.1

flavorjones · flavorjones · commit 7c34062b38aa · 2024-09-24T17:02:42.000-04:00
This version contains protections against sqlite's lack of fork safety. We also suppress the warnings related to forking with open writable connections, despite the lost memory per-connection. For more context, see: https://github.com/sparklemotion/sqlite3-ruby/blob/main/adr/2024-09-fork-safety.md
diff --git a/Gemfile b/Gemfile
@@ -158,7 +158,7 @@ platforms :ruby, :windows do
   gem "nokogiri", ">= 1.8.1", "!= 1.11.0"
 
   # Active Record.
-  gem "sqlite3", ">= 2.0"
+  gem "sqlite3", ">= 2.1"
 
   group :db do
     gem "pg", "~> 1.3"
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
@@ -11,9 +11,12 @@
 require "active_record/connection_adapters/sqlite3/schema_dumper"
 require "active_record/connection_adapters/sqlite3/schema_statements"
 
-gem "sqlite3", ">= 2.0"
+gem "sqlite3", ">= 2.1"
 require "sqlite3"
 
+# Suppress the warning that SQLite3 issues when open writable connections are carried across fork()
+SQLite3::ForkSafety.suppress_warnings!
+
 module ActiveRecord
   module ConnectionAdapters # :nodoc:
     # = Active Record SQLite3 Adapter
diff --git a/railties/lib/rails/generators/database.rb b/railties/lib/rails/generators/database.rb
@@ -248,7 +248,7 @@ def port
         end
 
         def gem
-          ["sqlite3", [">= 2.0"]]
+          ["sqlite3", [">= 2.1"]]
         end
 
         def base_package
diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb
@@ -436,7 +436,7 @@ def test_gemfile_has_no_whitespace_errors
   def test_config_database_is_added_by_default
     run_generator
     assert_file "config/database.yml", /sqlite3/
-    assert_gem "sqlite3", '">= 2.0"'
+    assert_gem "sqlite3", '">= 2.1"'
   end
 
   def test_config_mysql_database
diff --git a/railties/test/generators/db_system_change_generator_test.rb b/railties/test/generators/db_system_change_generator_test.rb
@@ -128,7 +128,7 @@ class ChangeGeneratorTest < Rails::Generators::TestCase
 
             assert_file("Gemfile") do |content|
               assert_match "# Use sqlite3 as the database for Active Record", content
-              assert_match 'gem "sqlite3", ">= 2.0"', content
+              assert_match 'gem "sqlite3", ">= 2.1"', content
             end
 
             assert_file("Dockerfile") do |content|
