Add --preload option to pin command#298
Merged
rafaelfranca merged 1 commit intorails:mainfrom Jul 9, 2025
3v0k4:preload
Merged
Add --preload option to pin command#298rafaelfranca merged 1 commit intorails:mainfrom 3v0k4:preload
--preload option to pin command#298rafaelfranca merged 1 commit intorails:mainfrom
3v0k4:preload
Conversation
--preload option to pin command--preload option to pin command
--preload option to pin command--preload option to pin command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HotDocs installer, I'd like to specify the preload when
pinning a package. Otherwise, I'd need to manually fiddle with theconfig/importmap.rbfile.This PR takes care of two things:
--preloadoption topin(e.g.,bin/importmap pin --preload=false lunr,bin/importmap pin --preload=application --preload=alternate lunr) in the second commit; see the test for the specifics on the behaviorThanks for your work on this gem!