Allows preload to be determined by provided entry_point#253
Merged
dhh merged 4 commits intorails:mainfrom Sep 15, 2024
aseroff:multiplemaps
Merged
Allows preload to be determined by provided entry_point#253dhh merged 4 commits intorails:mainfrom aseroff:multiplemaps
dhh merged 4 commits intorails:mainfrom
aseroff:multiplemaps
Conversation
|
hi, any updates on this? :) |
Contributor
Author
|
@jan-bw none from me. Not sure how to get maintainer eyes on this, but I do know there are maintainer eyes on a different approach to the same issue in a different pull request, so they may go with that one instead of this one. |
|
Hey man, any updates? would be fine to merge this PR! |
Contributor
Author
|
Nothing more to add from me @loqimean ! |
|
Finally!!!))) 🎉 🎉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #240 (comment), this PR allows preload to accept 1+ strings representing entry_points instead of just a boolean for the value of a mapping's preload. That way you can forgo creating multiple importmaps and instead use an application-wide importmap and modify what is preloaded based on where you are.