Updated module_name regexp to not match incorrect indexes#238
Merged
rafaelfranca merged 1 commit intorails:mainfrom Apr 19, 2024
Merged
Updated module_name regexp to not match incorrect indexes#238rafaelfranca merged 1 commit intorails:mainfrom
rafaelfranca merged 1 commit intorails:mainfrom
Conversation
|
looks good to me! looks better than my solution i think: mylons@c5cb32b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_index.jshaveindexreplaced with an empty string #215This updates the regex used to identify index files to ensure that modules like
foo/special_indexdon't get mapped tofoo.The cause of the problem was that the previous regex matched 1 or 0
/characters, which meant anything followed byindexand the end of the string, would qualify. We now ensure that we match either the start of the string or/