Add package information in vendored package file#227
Merged
dhh merged 1 commit intorails:mainfrom Jan 23, 2024
Merged
Conversation
Now that the packages are downloaded by default, apart from the output of the `pin` command we lose the track of the version and from where the package was downloaded. To track the version the solution was use a comment in bin/importmap next to the package version but nothing for the package origin so the proposal is add a comment in the first line of the downloaded package displaying the package name, version and from where it was downloaded.
Member
|
Clever! I like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that the packages are downloaded by default, apart from the output of the
pincommand we lose the track of the version and from where the package was downloaded. To track the version the solution was use a comment in bin/importmap next to the package version but nothing for the package origin so the proposal is add a comment in the first line of the downloaded package displaying the package name, version and from where it was downloaded.