Remove .raidionics/ directory during install and uninstall for Windows#36
Merged
dbouget merged 5 commits intoraidionics:masterfrom Apr 4, 2023
Merged
Remove .raidionics/ directory during install and uninstall for Windows#36dbouget merged 5 commits intoraidionics:masterfrom
dbouget merged 5 commits intoraidionics:masterfrom
Conversation
Member
Author
|
Could be an idea to delete the .raidionics/ directory the first time the program is being launched, if there is a sensible way of catching that (before creating it again, that is). |
…DME refactor [no ci]
Member
Author
|
I highlighted it better that the user needs to delete the Again, as there is no natural way to delete the |
Member
Author
|
I also cropped the GIF in the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to issue #5.
Note that this PR only adds the fix for Windows, but I believe this is most critical there as most of the users are on Windows.
Doing the same for Linux is likely bad practice as the
.raidionics/directory is likely created in the home directory (see this discussion).For macOS, I'm really not sure if this makes sense, as deletion of app bundles are done in a very different way. The bundles themselves are essentially just folders which lie in
/Applicationsor similar. Deleting them means to delete the folder and nothing more. There is a discussion regarding this here.We should also consider creating the
.raidionics/directory in a different directory in the future. I believe theC:/Users/some-user/AppData/Local/might be suitable, but not sure.