This repository was archived by the owner on May 26, 2026. It is now read-only.
fix(KR-P2-PR84-TEST-FIX): swap stale dr_runbook assertion to kora_dna placeholder#97
Merged
Merged
Conversation
… placeholder Trivial test-side debt closure. PR #84 (KR-P2-RUNBOOKS-PANEL)'s test_get_runbook_content_404_for_unauthored_manifest_entry pinned dr_runbook as a missing manifest entry — at the time, none of the kora_docs/* runbooks were vendored. PR #86 (KR-P2-RUNBOOKS-AUTHOR 185bfff) since vendored dr_runbook.md + token_rotation_runbook.md. Auto-improvement worked exactly as PR #84's body predicted; the test just went stale. Swap to kora_dna (kora_docs/00_canonical_current_state/kora_dna.md), the still-placeholder entry from the same manifest. Kora's DNA reference doc isn't on a near-term vendoring plan, so the test should stay valid until substrate-team ships it (at which point the same swap-to-another-placeholder pattern applies — or rewrite to mock a synthetic missing entry abstractly). Verified current disk state matches expectation: PRESENT dr_runbook.md, token_rotation_runbook.md, docs/deploy-fly-io.md MISSING deploy_runbook.md, kora_dna.md ← test now uses kora_dna Tests-only change. 151/151 admin-panel suite green (was 150/151 before this fix per PR #95's note). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trivial test-side debt closure. PR #84 (KR-P2-RUNBOOKS-PANEL)'s `test_get_runbook_content_404_for_unauthored_manifest_entry` pinned `dr_runbook` as a missing manifest entry — at the time, none of the `kora_docs/*` runbooks were vendored. PR #86 (KR-P2-RUNBOOKS-AUTHOR, `185bfff`) since vendored `dr_runbook.md` + `token_rotation_runbook.md`. Auto-improvement worked exactly as PR #84's body predicted; the test just went stale.
Change
Swap to `kora_dna` (`kora_docs/00_canonical_current_state/kora_dna.md`), the still-placeholder entry from the same manifest. Kora's DNA reference doc isn't on a near-term vendoring plan.
Current disk state (verified)
When substrate-team eventually vendors `kora_dna.md` too, the same swap-to-another-placeholder pattern applies. Or rewrite the test to mock a synthetic missing manifest entry via monkeypatch — but that's a refactor, not a fix; deferred until the placeholder list runs out.
Test plan
🤖 Generated with Claude Code