Address browser testing issues on test machines #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@radumg Feel free to merge if the changes are okay and then I will run your branch on the self-serve one last time to make sure we are good |
7 tasks
Owner
|
Looking good from my iPhone review 📱 , like the new tests better than what I had 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses browser testing issues on test machines. Verifying content running in a browser process launched via Dynamo is difficult to maintain on the test machines as the browser settings can often be reset or modified. The original tests worked great locally but pop-up browser messages preventing the tests from successfully executing on the test machines. These changes simply the tests while not relying on the browser content.
Reviewers
@radumg