fix: [One-Time Password Field] truncate values that exceed the length when pasting#3551
Open
nayounsang wants to merge 3 commits intoradix-ui:mainfrom
Open
fix: [One-Time Password Field] truncate values that exceed the length when pasting#3551nayounsang wants to merge 3 commits intoradix-ui:mainfrom
nayounsang wants to merge 3 commits intoradix-ui:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6981e19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thanks! Mind adding a unit test to cover this case? |
Contributor
Author
|
@chaance I add todo test because |
Contributor
Author
it('should truncate pasted characters to the number of inputs', async () => {
const inputs = screen.getAllByRole<HTMLInputElement>('textbox', {
hidden: false,
});
const firstInput = inputs[0]!;
fireEvent.click(firstInput);
const pasteData = '123456789';
fireEvent.paste(firstInput, {
clipboardData: {
getData: () => pasteData
}
});
expect(getInputValues(inputs)).toBe('1,2,3,4,5,6');
});I found a way to fix the paste test so that it can simulate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #3550
sanitizeValue, and therefore, side effects are a concern, so verification is performed in the paste logic.@testing-library/user-eventare not assigned to input.Test with Storybook
Case: paste
124868392