feat(injected-css): optionally export css for consumer to import#3131
Closed
prests wants to merge 2 commits intoradix-ui:mainfrom
Closed
feat(injected-css): optionally export css for consumer to import#3131prests wants to merge 2 commits intoradix-ui:mainfrom
prests wants to merge 2 commits intoradix-ui:mainfrom
Conversation
Member
|
I appreciate the contribution and consideration of the tradeoffs here! I'm going to close this PR for now because a) there's a huge backlog I'm trying to clear out, and b) I'm not sure I fully understand the problem and solution at this point. Glad to continue the discussion here to see how we can move forward. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a POC for removing all of the inline styles for CSP safe alternatives. This is tied to this discussion.
This converts inline styles into css class equivalents, and exports them as part of the npm package. The idea is that consuming apps would import these css files as part of their build. I left this as a progressive enhancement where by providing
skipStyleInjectionit's assumed you're importing these CSS files, but consumers who are not can still use the injected inline styles.Looking for input on how to have one source of truth between the css file and the inline styles. I don't think there's an easy way to do it but was hoping to not have to change two places at once.