Remove use of cssText in react-focus-guards#2840
Merged
chaance merged 1 commit intoradix-ui:mainfrom Sep 27, 2024
Merged
Conversation
Member
|
@iliana I'd like to include this in the next release. Do you mind running |
Contributor
Author
|
I'm not familiar with yarn, so I'm not sure why this doesn't work: It seems like my yarn version is correct per the value in package.json: |
Contributor
Author
|
Evidently the merge from main caused the issue, yarn doesn't seem to be able to handle that. I rebased instead. |
Violates Content-Security-Policy unless `style-src: 'unsafe-inline'` is permitted otherwise.
b80ce43 to
fc53007
Compare
chaance
approved these changes
Sep 27, 2024
8 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
createFocusGuardcreates a<span>, then applies CSS to it usingcssText. This violates Content-Security-Policy unlessstyle-src: 'unsafe-inline'is permitted. Setting the individual properties is acceptable under a strict CSP.