Drop CheckVersion signed extension#458
Conversation
|
@geigerzaehler so the e2e tests fail because the wasm runtime expects the check version signed extension while the latest native runtime doesn't provide it 🙃 any idea of how we can work around this and with such changes to signed extensions? |
As mentioned on the issue, this change is a semantic change to the runtime and requires us to go through the upgrade process. |
e29484f to
41642e6
Compare
|
@geigerzaehler this is ready for review. In terms of how to deploy this change, see #464 (comment). Edit: Bumping to spec_version 6 since v5 is entering master soon... |
runtime/src/lib.rs
Outdated
| impl_name: create_runtime_str!("radicle-registry"), | ||
| spec_version: 4, | ||
| spec_version: 5, | ||
| impl_version: 4, |
|
Could you please create a follow-up issue to add this check again once we’ve figured out the client compatibility story? |
f182135 to
4f2d41b
Compare
It requires a client and a node interacting to use the same `spec_version` of the runtime, which is not something we want. Rather, we want those to be as compatible as technically possible, something we will tackle in the near future.
4f2d41b to
85dbb86
Compare
This version drops the `CheckVersion` signed extension.
85dbb86 to
dc09288
Compare
Closes #457
CheckVersionrequires a client and a node interacting to use the samespec_versionof the runtime, which is not something we want. Rather,we want those to be as compatible as technically possible, something we
will tackle in the near future.