RFR: statsd ingestion endpoint.#201
Conversation
There was a problem hiding this comment.
Not sure why this is var args?
There was a problem hiding this comment.
It's the same signature as Arrays.asList().
|
I like this PR. Seems like you are on the right track. |
…rior to serialization. Fixed those bugs and added tests to verify and look for regressions (we're relying on behavior of gson to determine long or double).
There was a problem hiding this comment.
It would be nice if all the boiler plate to parse the payload goes into their own file.
|
Mostly LGTM. (Pending my comments & nits). |
There was a problem hiding this comment.
What happens if IOError gets bubbled up? Are we catching it somewhere?
There was a problem hiding this comment.
it will get caught in the threadpool now and result in a 500.
…ly, as some AstyanaxWriter paths cannot handle string/boolean metrics. Share processors among HTTP handlers.
remove uncessary returns statement.
There was a problem hiding this comment.
Doesn't this mean we share the thread pool for statsd and regular metrics? I am fine with this approach. Just wanted to confirm that this is intentional.
There was a problem hiding this comment.
Yes, that was done intentionally.
|
+1 (pending fixing the nits) |
RFR: statsd ingestion endpoint.
A few things to know up front:
Sample ingestion format is found in blueflood-http/src/test/resources/sample_bundle.json.
This PR is closely related to the statsd-backend that currently lives at https://github.com/gdusbabek/blueflood-statsd-backend.