Skip to content

[3-1-stable] fix: malformed charset param (#2263)#2277

Merged
ioquatix merged 1 commit intorack:3-1-stablefrom
Earlopain:backport-2263
Jan 30, 2025
Merged

[3-1-stable] fix: malformed charset param (#2263)#2277
ioquatix merged 1 commit intorack:3-1-stablefrom
Earlopain:backport-2263

Conversation

@Earlopain
Copy link
Contributor

Backports #2263, and also closes #2276 (probably)

The changelog entry should probably be "Fixed" instead of "Changed".

Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to backport. CI failures look like problems in bake or bake-test-external. Hopefully @ioquatix can address them.

@ioquatix
Copy link
Member

ioquatix commented Jan 30, 2025

We may need to backport #2244

If a content type header is provided with a malformed part, there's no
nice way of interpreting it since instead of being a key/value pair it's
just a key.

Instead, we mimic the behaviour of query parameters and opt to return an
empty string in lieu of missing values—this way we can still identify
their presence, but won't blow up. The behaviour isn't identical, but
we're also not worried about backwards compatibility here (given the
alternative was exploding)
@ioquatix ioquatix merged commit edb0869 into rack:3-1-stable Jan 30, 2025
15 checks passed
@ioquatix ioquatix added this to the v3.1.9 milestone Jan 30, 2025
@ioquatix ioquatix self-assigned this Jan 30, 2025
@ioquatix
Copy link
Member

Released in v3.1.9.

@Earlopain
Copy link
Contributor Author

Thanks! The changelog on main also has this in the unreleased section now.

@Earlopain Earlopain deleted the backport-2263 branch January 31, 2025 08:10
@ioquatix
Copy link
Member

Thanks, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants