[3-1-stable] fix: malformed charset param (#2263)#2277
Merged
ioquatix merged 1 commit intorack:3-1-stablefrom Jan 30, 2025
Merged
[3-1-stable] fix: malformed charset param (#2263)#2277ioquatix merged 1 commit intorack:3-1-stablefrom
ioquatix merged 1 commit intorack:3-1-stablefrom
Conversation
jeremyevans
approved these changes
Jan 30, 2025
Contributor
jeremyevans
left a comment
There was a problem hiding this comment.
This makes sense to backport. CI failures look like problems in bake or bake-test-external. Hopefully @ioquatix can address them.
Member
|
We may need to backport #2244 |
If a content type header is provided with a malformed part, there's no nice way of interpreting it since instead of being a key/value pair it's just a key. Instead, we mimic the behaviour of query parameters and opt to return an empty string in lieu of missing values—this way we can still identify their presence, but won't blow up. The behaviour isn't identical, but we're also not worried about backwards compatibility here (given the alternative was exploding)
7a3e237 to
827e28b
Compare
Member
|
Released in |
Contributor
Author
|
Thanks! The changelog on main also has this in the unreleased section now. |
Member
|
Thanks, fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2263, and also closes #2276 (probably)
The changelog entry should probably be "Fixed" instead of "Changed".