Only digest body when body.to_ary is present#1876
Closed
Conversation
Contributor
|
The Rack 3 SPEC is that if body responds to We don't want everything that interacts with the body have to defensively check to see whether |
Author
|
@jeremyevans Sorry I didn't see that. I'll leave Rails team to make it compatible then, thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1748, the result of
body.to_arywill be sent directly intodigest_bodyfor generating etag digest. ButActionDispatch::Response::RackBody#to_aryalways returnsnil, which will causeNoMethodErrorwith this approach. Therefore, I think it makes sense to check if the result ofbody.to_aryis present before trying to generate digest from it.(It wasn't an issue before #1748 because Rack used to pass the
body(responds to#each) todigest_bodyinstead).