Fix Response methods (host, port, etc.) for IPv6#1538
Merged
jeremyevans merged 1 commit intoJan 30, 2020
Conversation
91060c6 to
5a4b2a0
Compare
jeremyevans
requested changes
Jan 30, 2020
5a4b2a0 to
a587d07
Compare
a587d07 to
e6d3242
Compare
jeremyevans
approved these changes
Jan 30, 2020
This was referenced Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about IPv6 format, you can correct tests and I'll adopt the code.