Remove dead code in multipart parser#1536
Merged
Merged
Conversation
This can only be hit if filename is nil/false. However, when the MimePart is created, it is either a TempfilePart if there is a filename or a BufferPart otherwise. In the TempfilePart case, the filename is present so this code is not hit. In the BufferPart case, the body is a String and not an IO, so this cannot be hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can only be hit if filename is nil/false. However, when
the MimePart is created, it is either a TempfilePart if there
is a filename or a BufferPart otherwise. In the TempfilePart
case, the filename is present so this code is not hit. In the
BufferPart case, the body is a String and not an IO, so this
cannot be hit.