Skip to content

use broccoli-funnel to allow excluding files/folders using regex#9

Merged
ssured merged 1 commit intoracido:masterfrom
craigteegarden:enable-regex-for-exclusion
Apr 30, 2015
Merged

use broccoli-funnel to allow excluding files/folders using regex#9
ssured merged 1 commit intoracido:masterfrom
craigteegarden:enable-regex-for-exclusion

Conversation

@craigteegarden
Copy link
Copy Markdown
Contributor

This PR replaces broccoli-file-remover with broccoli-funnel (https://github.com/broccolijs/broccoli-funnel) which allows excluding files from the tree using regular expressions.

We wanted to exclude all .map files, but they are automatically generated and there didn't seem to be a way to use the existing broccoli-file-remover with a glob/wildcard pattern.

This allows something like this to correctly remove index.html and any .map files from the output:

    manifest : {
      enabled: true,
      appcacheFile: "/manifest.appcache",
      excludePaths: ['index.html', new RegExp(/.\.map$/)],
      includePaths: [''],
      network: ['*']
    },

Thoughts?

@ssured
Copy link
Copy Markdown
Contributor

ssured commented Apr 30, 2015

Nice addition. I was unaware of the existence of broccoli-funnel . I'll pull in, thanks!

@ssured ssured merged commit 0503c63 into racido:master Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants