Fix nethogsmonitor_loop_devices_py to accept more than one device #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the ref only the last element of __devicenames is stored in _devicenames: The temporary is deleted at the end of the for body, therefore the pointer to the c_str is no longer valid and might be reused by the implementation. By using a reference in the for head the c_str does not return a ref to the temporary but to the original array wich's lifetime is till the end of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the ref only the last element of
__devicenamesis stored in_devicenames: The temporary is deleted at the end of the for body, therefore the pointer to thec_stris no longer valid and might be reused by the implementation. By using a reference in the for head thec_strdoes not return a ref to the temporary but to the original array wich's lifetime is till the end of the function.