Skip to content

Port tutorials to Elixir#136

Merged
michaelklishin merged 7 commits into
rabbitmq:masterfrom
jeffweiss:add_elixir_tutorial
Feb 7, 2016
Merged

Port tutorials to Elixir#136
michaelklishin merged 7 commits into
rabbitmq:masterfrom
jeffweiss:add_elixir_tutorial

Conversation

@jeffweiss

@jeffweiss jeffweiss commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@jeffweiss jeffweiss mentioned this pull request Jan 8, 2016
Merged
michaelklishin
michaelklishin reviewed Jan 9, 2016
View reviewed changes
Comment thread site/tutorials/tutorial-two-elixir.md

@michaelklishin michaelklishin Jan 9, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hello" should be "task_queue"

@michaelklishin

michaelklishin commented Jan 9, 2016

Copy link
Copy Markdown
Contributor

Please submit this against the live branch. master will only be deployed with RabbitMQ 3.7.0, more than 6 months from now.

@michaelklishin

michaelklishin commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

@jeffweiss thank you. This PR needs some work, please see the comments above.

@jeffweiss

jeffweiss commented Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

Noted. I'll make the changes are resubmit against the live branch.

@michaelklishin michaelklishin changed the title Add elixir tutorial DO NOT MERGE Add Elixir tutorial Jan 12, 2016
@michaelklishin michaelklishin self-assigned this Jan 12, 2016
@michaelklishin

michaelklishin commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

@bdshroyer when you have a chance (and get to other Elixir-related things we've discussed), feel free to finish this and merge. Website changes that we'd like to deploy quickly should be based on the live branch. stable is for 3.6.x release (at the moment) and master is for the next feature release (3.7.0 at the moment).

@michaelklishin michaelklishin merged commit a03e688 into rabbitmq:master Feb 7, 2016
@michaelklishin michaelklishin changed the title DO NOT MERGE Add Elixir tutorial Port tutorials to Elixir Feb 7, 2016
@michaelklishin

michaelklishin commented Feb 7, 2016

Copy link
Copy Markdown
Contributor

I've corrected a few things in tutorial two. We now have enough tutorials that I had to rework our getting started guide ;) Thank you, @jeffweiss, it's already live.

@michaelklishin

michaelklishin commented Feb 7, 2016

Copy link
Copy Markdown
Contributor

Oh, and to push it live, I cherry-picked relevant commits from master.

@jeffweiss

jeffweiss commented Feb 7, 2016

Copy link
Copy Markdown
Contributor Author

Sorry I've been non-responsive. I've really been underwater and ill lately. Thanks for making it happen.

@jeffweiss jeffweiss deleted the add_elixir_tutorial branch February 7, 2016 02:28
@michaelklishin

michaelklishin commented Feb 7, 2016

Copy link
Copy Markdown
Contributor

@jeffweiss no worries. Get well soon!

@jeffweiss

jeffweiss commented Feb 7, 2016

Copy link
Copy Markdown
Contributor Author

💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelklishin michaelklishin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffweiss @michaelklishin @bdshroyer