rabbit_stream_manager: Handle internal_error in stream declaration (backport #15699)#15702
Merged
the-mikedavis merged 1 commit intov4.2.xfrom Mar 11, 2026
Merged
Conversation
`rabbit_stream_queue:declare/2` may fail to declare if the metadata
store operation(s) time out, like when the cluster has a minority of
online nodes. This would cause a case_clause error in
`rabbit_stream_manager:do_create_stream/4`. We can print a warning
log and return `{error, internal_error}` instead.
(cherry picked from commit d9350fe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rabbit_stream_queue:declare/2may fail to declare if the metadata store operation(s) time out, like when the cluster has a minority of online nodes. This would cause a case_clause error inrabbit_stream_manager:do_create_stream/4. We can print a warning log and return{error, internal_error}instead.This is an automatic backport of pull request #15699 done by Mergify.