rabbit_fifo: Use optimised tuple for delayed keys#15649
Merged
Conversation
1899d53 to
acbd708
Compare
This is a very small space-saving measure. `{ReadyAtMillis, MsgIdx}`
becomes `[ReadyAtMillis | MsgIdx]` for the `#delayed{}` state, saving a
small number of bytes per key when serialized. This optimised tuple type
is already used in a few other places in `rabbit_fifo` for a similar
space-saving effect.
`gb_trees:size/1` is constant time - the size is stored at the top-level
tuple.
-doc "Returns the number of nodes in `Tree`.".
-spec size(Tree) -> non_neg_integer() when
Tree :: tree().
size({Size, _}) when is_integer(Size), Size >= 0 ->
Size.
So we don't need to manually track the tree size with a len field. This
change removes the field.
acbd708 to
8498e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small space-saving measure.
{ReadyAtMillis, MsgIdx}becomes[ReadyAtMillis | MsgIdx]for the#delayed{}state, saving a small number of bytes per key when serialized. This optimised tuple type is already used in a few other places inrabbit_fifofor a similar space-saving effect.There is also a commit to remove
#delayed.lensince the tree size is already tracked at the top-level tuple of agb_trees:tree().