Per-object Prometheus metrics: avoid duplicate HELP, TYPE metadata lines (backport #15610)#15632
Merged
michaelklishin merged 3 commits intov4.2.xfrom Mar 4, 2026
Merged
Conversation
for Raft metrics. Raft metrics can and do come from different Ra systems, namely Khepri and quorum queues. We need to format them as a "single" metric to avoid duplicate HELP, TYPE metadata lines. Since quorum queues have dozens of metrics, we filter out a set of Raft-related ones specifically that combine well with the Raft metrics from Khepri. Closes #15600. (cherry picked from commit e374715)
Previously a missing metric was ignored. (cherry picked from commit e34e5f0)
(cherry picked from commit f26cde6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if this is the optimal approach but it is best place/manner of addressing this that I could find without affecting aggregated metrics.
Raft metrics can and do come from different Ra systems, namely Khepri and quorum queues. We need to format them as a "single" metric to avoid duplicate HELP, TYPE metadata lines.
Since quorum queues have dozens of metrics, we filter out a set of Raft-related ones specifically that combine well with the Raft metrics from Khepri.
Closes #15600.
This is an automatic backport of pull request #15610 done by [Mergify](https://mergify.com).