Conversation
…bers [Why] If `rabbit_mnesia:members/0` hit an error, it always returned the node itself. `rabbit_khepri:members/0` returns an empty list to distinguish an error and let the caller handle it. When peer discovery queries the cluster members ant it fails, it didn't handle the empty list so far. This led to errors while sorting nodes to determine which one to use as the cluster seed. [How] If `rabbit_nodes:list_members/0` returns an empty list, the code assumes that the node is alone/unclustered (i.e. like what would be implicitly done if Mnesia was used). (cherry picked from commit c402032)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
If
rabbit_mnesia:members/0hit an error, it always returned the node itself.rabbit_khepri:members/0returns an empty list to distinguish an error and let the caller handle it.When peer discovery queries the cluster members ant it fails, it didn't handle the empty list so far. This led to errors while sorting nodes to determine which one to use as the cluster seed.
How
If
rabbit_nodes:list_members/0returns an empty list, the code assumes that the node is alone/unclustered (i.e. like what would be implicitly done if Mnesia was used).This is an automatic backport of pull request #15568 done by Mergify.