Definition import: strip UTF BOM (backport #15550)#15553
Merged
michaelklishin merged 2 commits intov4.2.xfrom Feb 24, 2026
Merged
Definition import: strip UTF BOM (backport #15550)#15553michaelklishin merged 2 commits intov4.2.xfrom
michaelklishin merged 2 commits intov4.2.xfrom
Conversation
The UTF-8 BOM (byte order mark, EF BB BF) is a three-byte sequence that some editors prepend to UTF-8 encoded files. The JSON parser does not strip it automatically, causing definition import to fail with a JSON parse error. Add a pattern-match clause to the decode/1 functions in both rabbit_definitions and rabbit_mgmt_wm_definitions to strip the BOM before attempting to parse the body as JSON. (cherry picked from commit 26b7bc1)
Originally proposed in #15527. Borrows a function from our rabbitmq.conf parser, see Kyorai/cuttlefish#64. Fixes #13748. (cherry picked from commit 7ef3936)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition import: strip leading UTF BOM
Originally proposed in #15527 by @danielalanbates.
Borrows a function from our rabbitmq.conf parser,
see Kyorai/cuttlefish#64.
Fixes #13748.
This is an automatic backport of pull request #15550 done by Mergify.