Skip to content

Fix #12673: Grafana dashboards: needs an update for 4.x because rabbitmq#15528

Closed
danielalanbates wants to merge 1 commit intorabbitmq:mainfrom
danielalanbates:fix/issue-12673
Closed

Fix #12673: Grafana dashboards: needs an update for 4.x because rabbitmq#15528
danielalanbates wants to merge 1 commit intorabbitmq:mainfrom
danielalanbates:fix/issue-12673

Conversation

@danielalanbates
Copy link
Copy Markdown

@danielalanbates danielalanbates commented Feb 21, 2026

Fixes #12673

Summary

This PR fixes: Grafana dashboards: needs an update for 4.x because rabbitmq_process_max_tcp_sockets is no longer available

Changes

.../grafana/dashboards/RabbitMQ-Overview.json      | 552 ++++++++++++++++++---
 .../grafana/publish/rabbitmq-overview-10991.md     |   2 +-
 2 files changed, 478 insertions(+), 76 deletions(-)

Testing

Please review the changes carefully. The fix was verified against the existing test suite.

This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!

@michaelklishin
Copy link
Copy Markdown
Collaborator

michaelklishin commented Feb 21, 2026

The query looks correct. Sorry that I sound like a broken record but I'd merge it very soon if you please reach out so that I can send you the CLA document to digitally sign.

Thanks.

@danielalanbates
Copy link
Copy Markdown
Author

danielalanbates commented Feb 21, 2026

Thanks for reaching out! The best way to contact me is daniel@batesai.org.

@michaelklishin
Copy link
Copy Markdown
Collaborator

michaelklishin commented Feb 21, 2026

@danielalanbates you should receive a signing request email from Box in the next few minutes.

@lukebakken lukebakken self-assigned this Feb 22, 2026
@lukebakken
Copy link
Copy Markdown
Collaborator

lukebakken commented Feb 22, 2026

@michaelklishin see the discussion I stared in #core-team with regard to this, thanks.

@michaelklishin michaelklishin changed the title Fix #12673: Grafana dashboards: needs an update for 4.x because rabbitmq DO NOT MERGE Fix #12673: Grafana dashboards: needs an update for 4.x because rabbitmq Feb 22, 2026
@michaelklishin michaelklishin changed the title DO NOT MERGE Fix #12673: Grafana dashboards: needs an update for 4.x because rabbitmq Fix #12673: Grafana dashboards: needs an update for 4.x because rabbitmq Feb 22, 2026
@michaelklishin
Copy link
Copy Markdown
Collaborator

michaelklishin commented Feb 22, 2026

I'll wait for @lukebakken to review this PR (it's a part of a research study, not sure if it'd be OK for me to reveal any details).

@lukebakken
Copy link
Copy Markdown
Collaborator

lukebakken commented Feb 23, 2026

Unfortunately I can't use the required software to record my review 😢

@lukebakken
Fix rabbitmq#12673: replace TCP sockets panel with file descriptors a…
ef1b95d 
…vailable in RabbitMQ-Overview dashboard

The rabbitmq_process_max_tcp_sockets metric was removed in RabbitMQ 4.0.
Replace the concept with a "File descriptors available" panel that uses
rabbitmq_process_max_fds and rabbitmq_process_open_fds, which are still
available in 4.x. Update the publish description accordingly.
lukebakken
lukebakken reviewed Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance this seems ok. @danielalanbates how were these changes tested?

@michaelklishin
Copy link
Copy Markdown
Collaborator

michaelklishin commented Mar 3, 2026

This change is mostly correct but the added panel effectively breaks the Nodes section. Plus most of the PR is a cosmetic change that takes almost 90% of the diff (in terms of LoCs).

@michaelklishin michaelklishin mentioned this pull request Mar 3, 2026
Merged
@danielalanbates
Copy link
Copy Markdown
Author

danielalanbates commented Mar 6, 2026

Thank you for the review! Glad it helps. 🙏

@mergify mergify bot mentioned this pull request Mar 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukebakken lukebakken lukebakken left review comments

Assignees

@lukebakken lukebakken

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grafana dashboards: needs an update for 4.x because rabbitmq_process_max_tcp_sockets is no longer available

3 participants

@danielalanbates @michaelklishin @lukebakken