Merge stream.read_ahead and stream.read_ahead_limit options (backport #14894)#14948
Merged
the-mikedavis merged 1 commit intov4.2.xfrom Nov 13, 2025
Merged
Merge stream.read_ahead and stream.read_ahead_limit options (backport #14894)#14948the-mikedavis merged 1 commit intov4.2.xfrom
stream.read_ahead and stream.read_ahead_limit options (backport #14894)#14948the-mikedavis merged 1 commit intov4.2.xfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
01979d8 to
bfe6054
Compare
Collaborator
|
Oh, I guess my last backport I messed up the conflicts and introduced a duplicate definition rabbitmq-server/deps/rabbit/priv/schema/rabbit.schema Lines 2779 to 2795 in 7e43377 Working on the fix... |
Read-ahead can be controlled by a single option, with zero acting the same as `false`. (cherry picked from commit 76ce4ee) # Conflicts: # deps/rabbit/src/rabbit_stream_queue.erl
bfe6054 to
7b93c92
Compare
|
|
||
| %% See github.com/rabbitmq/osiris#192 and https://github.com/rabbitmq/rabbitmq-server/commit/9f162dfd01c1516d168e7d1fad39d33a929756e5 | ||
| %% Enables read-head | ||
| {mapping, "stream.read_ahead", "rabbit.stream_read_ahead", |
Collaborator
There was a problem hiding this comment.
I accidentally moved or duplicated this last time
| []}, | ||
|
|
||
| %% | ||
| %% Stream read ahead on/off |
Collaborator
There was a problem hiding this comment.
Same here, this was duplicated, probably because of conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-ahead can be controlled by a single option, with zero acting the same as
false.This is the companion change for rabbitmq/osiris#199 - see extra context there. This replaces the config option in #14888.
This is an automatic backport of pull request #14894 done by [Mergify](https://mergify.com).