Make 'queue.declare' aware of virtual host DQT at validation time (backport #11541)#11548
Closed
mergify[bot] wants to merge 4 commits intov3.13.xfrom
Closed
Make 'queue.declare' aware of virtual host DQT at validation time (backport #11541)#11548mergify[bot] wants to merge 4 commits intov3.13.xfrom
mergify[bot] wants to merge 4 commits intov3.13.xfrom
Conversation
Author
|
Cherry-pick of f3b7a34 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
|
@Mergifyio rebase |
at validation time. DQT = default queue type. When a client provides no queue type, validation should take the defaults (virtual host, global, and the last resort fallback) into account instead of considering the type to be "undefined". References #11457 ##11528 (cherry picked from commit f3b7a34) # Conflicts: # deps/rabbit/src/rabbit_queue_type.erl # deps/rabbit/src/rabbit_vhost.erl
Besides fixing a regression detected by priority_queue_SUITE, this introduces a drive-by change: rabbit_priority_queue: avoid an exception when max priority is a negative value that circumvented validation (cherry picked from commit 1a48bb7)
…ncompatible (cherry picked from commit 2e5cb21)
(cherry picked from commit 31dc3b8)
Author
✅ Branch has been successfully rebased |
d7283b2 to
5fe4cd7
Compare
Collaborator
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DQT = default queue type.
Determining what queue type should be used is getting more and more involved.
It can come from four different places:
x-queue-typeargument value) or the HTTP APIrabbitmq.conf"classic")In addition, there are two ways to specify a type:
"quorum"rabbit_classic_queueWhen a client provides no queue type, validation
should take the defaults (virtual host, global,
and the last resort fallback) into account
instead of considering the type to be "undefined".
References #11457 ##11528.
This is an automatic backport of pull request #11541 done by [Mergify](https://mergify.com).