Definition export: inject default queue type into virtual host metadata#12821
Definition export: inject default queue type into virtual host metadata#12821michaelklishin merged 8 commits intomainfrom
Conversation
|
All the parts you've worked on so far work well for me. There's one more endpoint which I think should Additionally, |
|
@mkuratczyk ready for another round. |
mkuratczyk
left a comment
There was a problem hiding this comment.
Works great, thanks. The only thing that I wasn't 100% sure about is that
if you export definitions with a DQT set and import them to a fresh node (that just defaults to classic), the DQT doesn't get set to the value from the definitions JSON.
But given that imports are additive, I think that's ok - we are not overriding an existing value.
Definition export: inject default queue type into virtual host metadata (backport #12821)
|
Highly relevant: https://github.com/michaelklishin/rabbitmq-3.13-dqt-bug-reproduction/. |
With this change,
GET /api/definitionsandGET /api/vhostswill inject a default queue type (DQT) into virtual host metadata whendefault_queue_typeis set inrabbitmq.conf(v4.0.x-only) and the virtual host in question does not have DQT defined for it:default_queue_type = quorumCloses #12776.
Closes #12835.