[Suggestion] Clear internal at-least-once dead-letter queue on QQ purge? #15562
-
RabbitMQ series4.2.x Operating system (distribution) usedLinux How is RabbitMQ deployed?RabbitMQ-as-a-Service from a public cloud provider What would you like to suggest for a future version of RabbitMQ?Purging a queue resets it sort of similarly to if you deleted the queue and redeclared it. I have seen in a few cases that someone using the QQ at-least-once dead-lettering feature with a misconfiguration like a non-existent DLQ or DLX or binding is surprised that purging the origin QQ does not release the disk footprint of the queue. Instead you must either make the dead-lettered message(s) routable or delete+redeclare the queue. I wonder if purging a QQ with at-least-once dead-lettering configured should also clear the internal dead-letter queue? I think this would make sense intuitively as "purge" is a sort of reset / clear operation. Maybe I am not thinking this through all the way, and it would be surprising if you dead-lettered and then immediately purged though? |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 3 replies
-
|
With compaction (rabbitmq/ra#494) the disk space footprint concern is less pressing since a small number of dead-lettered messages would not prevent the cleanup of the rest of the log. But even with compaction I wonder if it would not be less surprising if it cleared the dead lettered messages? |
Beta Was this translation helpful? Give feedback.
-
|
To protect against the specific case where DLX cannot succeed and keeps retrying I'd say yes, we should clear the unpublished dead-lettered messages. |
Beta Was this translation helpful? Give feedback.
-
|
I removed that purge in 5860301 for no real good reason. |
Beta Was this translation helpful? Give feedback.
-
|
I added this TODO to #13885 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Great, thanks! I was going to send a PR but it will need a new machine version so it definitely needs to be mixed in with the v3 changes. I'll send a PR when I can, if it's not already done by then |
Beta Was this translation helpful? Give feedback.
-
|
Solved in #13885 |
Beta Was this translation helpful? Give feedback.
Solved in #13885