Test rolling upgrade of federation mirrored supervisors

gomoripeti · gomoripeti · commit 4eca000de63c · 2026-01-12T23:04:36.000+01:00
Without the patch the test case rolling_upgrade:child_id_format fails with:
```
=== Location: [{erpc,call,1366},
              {exchange_SUITE,'-child_id_format/1-fun-5-',675},
              {lists,foreach_1,2310},
              {exchange_SUITE,child_id_format,670},
              {test_server,ts_tc,1794},
              {test_server,run_test_case_eval1,1303},
              {test_server,run_test_case_eval,1235}]
=== === Reason: {exception,
                     {noproc,
                         {gen_server,call,
                             [rabbit_federation_exchange_link_sup_sup,
                              which_children,infinity]}}}
```
diff --git a/deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl b/deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl
@@ -167,6 +167,7 @@
 
     enable_plugin/3,
     disable_plugin/3,
+    set_plugins/3,
 
     test_channel/0,
     test_writer/1,
@@ -2415,6 +2416,9 @@ enable_plugin(Config, Node, Plugin) ->
 disable_plugin(Config, Node, Plugin) ->
     plugin_action(Config, Node, [disable, Plugin]).
 
+set_plugins(Config, Node, PluginList) ->
+    plugin_action(Config, Node, [set | PluginList]).
+
 plugin_action(Config, Node, Args) ->
     NodeConfig = get_node_config(Config, Node),
     Nodename = ?config(nodename, NodeConfig),
diff --git a/deps/rabbitmq_exchange_federation/test/exchange_SUITE.erl b/deps/rabbitmq_exchange_federation/test/exchange_SUITE.erl
@@ -580,14 +580,14 @@ lookup_exchange_status(Config) ->
 
 child_id_format(Config) ->
   case rabbit_ct_helpers:is_mixed_versions() of
-    false ->
+    true ->
           [UpstreamNode,
            OldNodeA,
            NewNodeB,
            OldNodeC,
            NewNodeD] = rabbit_ct_broker_helpers:get_node_configs(
                          Config, nodename),
-          
+
           %% Create a cluster with the nodes running the old version of RabbitMQ in
           %% mixed-version testing.
           %%
@@ -603,7 +603,12 @@ child_id_format(Config) ->
           %% secondary umbrella, `NewNodeB' the primary copy, and so on.
           Config1 = rabbit_ct_broker_helpers:cluster_nodes(
                       Config, [OldNodeA, OldNodeC]),
-          
+
+          %% The old nodes get the "rabbitmq_exchange_federation" plugin enabled but that is not found
+          %% Let's switch to the old plugin name
+          [rabbit_ct_broker_helpers:set_plugins(Config, Node, ["rabbitmq_federation"])
+           || Node <- [OldNodeA, OldNodeC]],
+
           %% Prepare the whole federated exchange on that old cluster.
           UpstreamName = <<"fed_on_upgrade">>,
           rabbit_ct_broker_helpers:set_parameter(
@@ -691,9 +696,8 @@ child_id_format(Config) ->
                 when is_list(List) ->
                   {skip, "Testcase skipped with the transiently changed ID format"}
           end;
-      true ->
-          %% skip the test in mixed version mode
-          {skip, "Should not run in mixed version environments"}
+      false ->
+          {skip, "Should only run in mixed version environments"}
   end.
 
 %%
