Upgrade gen_batch_server to 0.10.0 and update WAL configuration#615
Merged
Upgrade gen_batch_server to 0.10.0 and update WAL configuration#615
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the gen_batch_server dependency and adjusts Ra’s WAL configuration defaults/options to match the new version and desired runtime behavior.
Changes:
- Bump
gen_batch_serverfrom0.9.2to0.10.0(rebar + erlang.mk/Makefile + lockfile). - Change the default
wal_hibernate_afterfromundefinedtoinfinityand update the public config type accordingly. - Consolidate WAL
gen_batch_serverstartup options and enableflush_mailbox_on_terminate.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ra_system.erl | Expands wal_hibernate_after type to allow infinity. |
| src/ra_log_wal.erl | Simplifies gen_batch_server:start_link/4 options; adds terminate mailbox flushing; sets hibernate_after default to infinity. |
| src/ra_log_sup.erl | Changes derived WAL config default for wal_hibernate_after to infinity. |
| rebar.lock | Locks gen_batch_server at 0.10.0 with updated hashes. |
| rebar.config | Updates gen_batch_server dependency version to 0.10.0. |
| Makefile | Updates dep_gen_batch_server to 0.10.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This update upgrades the gen_batch_server dependency from 0.9.2 to 0.10.0 and adjusts the WAL (Write-Ahead Log) configuration accordingly: - Update gen_batch_server dependency to 0.10.0 in Makefile and rebar.config - Change default wal_hibernate_after from undefined to infinity - Simplify and consolidate WAL options handling in ra_log_wal - Add flush_mailbox_on_terminate option with 10 mailbox summary messages - Update type specification for wal_hibernate_after to accept infinity
0ae451d to
529ce75
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update upgrades the gen_batch_server dependency from 0.9.2 to 0.10.0 and adjusts the WAL (Write-Ahead Log) configuration accordingly: