Different approach to corrupt config recovery.#614
Merged
Conversation
A new ra server needs to be registered before the log is initalised as the log init writes index 0. If they are not initialised the segment writer or even the WAL may drop the write or remove the mem table causing the member to crash shortly after. Instead we will handle corrupt config files in pre-init and unregister the UID if the config file is missing or does not contain a parsable erlang term.
ae8b3f9 to
eacc8f2
Compare
dumbbell
approved these changes
Mar 31, 2026
Collaborator
dumbbell
left a comment
There was a problem hiding this comment.
This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new ra server needs to be registered before the log is initalised as the log init writes index 0. If they are not initialised the segment writer or even the WAL may drop the write or remove the mem table causing the member to crash shortly after.
Instead we will handle corrupt config files in pre-init and unregister the UID if the config file is missing or does not contain a parsable erlang term.