fix: redirect client commands during await_condition#610
Merged
kjnilsson merged 1 commit intorabbitmq:mainfrom Mar 26, 2026
Merged
Conversation
kjnilsson
approved these changes
Mar 26, 2026
Contributor
|
great - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi — another small one I found while reading the await_condition path.
During leadership transfer, the node enters await_condition state. If a client command or query arrives in this window (e.g. forwarded by a follower), it hits the catch-all and gets dropped silently — the client never gets a reply back.
This adds a clause to redirect those requests to the current leader so the client can retry there instead of hanging.
BTW, that's the final issue I found. Thanks a lot!