fix: handle install_snapshot_rpc in candidate state#607
Merged
kjnilsson merged 1 commit intorabbitmq:mainfrom Mar 26, 2026
Merged
Conversation
kjnilsson
approved these changes
Mar 26, 2026
Contributor
|
thank you, good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for merging #600!
I noticed that handle_candidate doesn't have a clause for install_snapshot_rpc. If a lagging node becomes a candidate while the leader is trying to send it a snapshot, the snapshot message gets dropped and the candidate keeps running elections it can't win — its log is too far behind. Meanwhile the leader keeps trying to send the snapshot, which keeps getting ignored.
The fix adds an install_snapshot_rpc clause to handle_candidate that steps down to follower first (since only a valid leader sends snapshots), then processes the snapshot normally.