Segment writer: read the full snapshot state ETS record atomically.#591
Merged
Segment writer: read the full snapshot state ETS record atomically.#591
Conversation
The current approoch of reading the snapshot index then the live indexes is prone to a race condition where the snapshot state is updated in betweeen reading the snapshot index and the live indexes. E.g. Snapshot is taken at index 10 with [7, 5, 3, 1] Snapshot is taken at index 15 with [13, 11, 5, 3, 1] Segment writer reads live indexes [7, 5, 3, 1] but snapshot index 15. 13 and 11 will not be written but 7 will be unnecesarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current approoch of reading the snapshot index then the live indexes is prone to a race condition where the snapshot state is updated in betweeen reading the snapshot index and the live indexes.
E.g.
Snapshot is taken at index 10 with [7, 5, 3, 1]
Snapshot is taken at index 15 with [13, 11, 5, 3, 1]
Segment writer reads live indexes [7, 5, 3, 1] but snapshot index 15.
13 and 11 will not be written but 7 will be unnecesarily.