Skip to content

Handle DOWN signals in candidate state#588

Merged
kjnilsson merged 1 commit intorabbitmq:mainfrom
emqx:fix/candidate-monitor-loss
Mar 5, 2026
Merged

Handle DOWN signals in candidate state#588
kjnilsson merged 1 commit intorabbitmq:mainfrom
emqx:fix/candidate-monitor-loss

Conversation

@keynslug
Copy link
Copy Markdown
Contributor

@keynslug keynslug commented Mar 5, 2026

Proposed Changes

This PR adds a couple of missing clauses to candidate state handler to make it handle process monitor and node signals consistently with other states. This, for example, prevents aux handlers from losing monitor signal emitted when the server is in candidate state.

Types of Changes

  • Bug fix (non-breaking change which fixes issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@kjnilsson kjnilsson merged commit b7131e8 into rabbitmq:main Mar 5, 2026
7 checks passed
@michaelklishin michaelklishin added this to the 3.0.0 milestone Mar 5, 2026
@keynslug keynslug deleted the fix/candidate-monitor-loss branch March 11, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants